From 109e33106881b8d48302aeab1ea679a66aa8c2ae Mon Sep 17 00:00:00 2001 From: yhirose Date: Wed, 29 Apr 2026 09:41:39 +0900 Subject: [PATCH] Exclude *_Online tests from default CI runs These tests reach out to external services (httpbin, YouTube, ...) and flake on CI runners whenever those services are slow or unreachable. The previous shard runner script silently masked these failures; now that runs report them faithfully, default the filter to -*_Online. Override via workflow_dispatch + the gtest_filter input to include them when explicitly desired. Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/test.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 0aa2304..212cc15 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -25,7 +25,9 @@ concurrency: cancel-in-progress: true env: - GTEST_FILTER: ${{ github.event.inputs.gtest_filter || '*' }} + # Exclude *_Online tests by default — they hit external services and flake on + # CI runners. Run with workflow_dispatch + a custom filter to include them. + GTEST_FILTER: ${{ github.event.inputs.gtest_filter || '-*_Online' }} jobs: style-check: @@ -323,7 +325,7 @@ jobs: for ($i = 0; $i -lt $shards; $i++) { $log = "shard_${i}.log" $procs += Start-Process -FilePath ./Release/httplib-test.exe ` - -ArgumentList "--gtest_color=yes","--gtest_filter=${{ github.event.inputs.gtest_filter || '*' }}" ` + -ArgumentList "--gtest_color=yes","--gtest_filter=${{ github.event.inputs.gtest_filter || '-*_Online' }}" ` -NoNewWindow -PassThru -RedirectStandardOutput $log -RedirectStandardError "${log}.err" ` -Environment @{ GTEST_TOTAL_SHARDS="$shards"; GTEST_SHARD_INDEX="$i" } }